platform.txt: don't set compiler.warning_flags to -w #2784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makeEspArduino doesn't have any menu logic, so it uses compiler.warning_flags rather than one of the compiler.warning_flags.* properties. The GCC option "-w" isn't overridable, so there's no way for the user to enable warnings. Set compiler.warning_flags to the same value as compiler.warning_flags.default, i.e. empty, to fix this.
Current coverage is 27.80% (diff: 100%)@@ master #2784 diff @@
==========================================
Files 20 20
Lines 3625 3625
Methods 335 335
Messages 0 0
Branches 656 656
==========================================
Hits 1008 1008
Misses 2441 2441
Partials 176 176
|
|
This is simple enough for us to either merge in 2.6.0 or close as a won't merge, to declutter the PR list. |
|
Closing as won't merge. I checked other Arduino platform.txts and our setting matches theirs so we're consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makeEspArduino doesn't have any menu logic, so it uses
compiler.warning_flags rather than one of the compiler.warning_flags.*
properties. The GCC option "-w" isn't overridable, so there's no way
for the user to enable warnings.
Set compiler.warning_flags to the same value as
compiler.warning_flags.default, i.e. empty, to fix this.